Script Help PhP

[Legacy]

I have this ladder script that I purchased and the Creator will not support or help me with a major bug in it.

What is happening is a team CHALLENGES another team to a battle on the Ladder. Then the Other Team RESPONDS to the challenge. Now if the ORIGINAL Team who made the challenge DOES NOT Finalize the match withing 48 hrs then the script executes a FORFEIT..but the problem is the script is creating the FORFEIT to the team that was challenged even tho they responded to the original challenge..it should give the fofeit to the Orginal Team because they didnt FINALIZE the match. I have found the section of code in the script that creates the forfeits..any help would be appreciated.

The Script is Running here:
http://www.squadgames.com/ladder_network

here is a URL with screenshots of what is happening
http://www.squadgames.com/legacy/ladderscript2_bug.php

I think it needs more code added to work properly..but i dont know about this stuff

I really could use some help with this..It Gives a forfeit to the wrong team and after paying $400.00 for this script the creator wont help me and the script is Useless.
also if you need more files e-mail me at admin@squadgames.com I'll provide anything you might need
------------------------------------------------------------------------------

PHP Code:

//NEXT 2 FUNCTIONS DELETES AND AWARDS WINS FOR UNRESPONDED OR UNFINALIZED CHALLENGES 


function check_unrespondedchallenges(){ 

$challengeladders=mysql_query("SELECT id,respondhours,finalizehours FROM ladders WHERE challenge='1'"); 
while(list($id,$respondhours,$finalizehours)=mysql_fetch_row($challengeladders)){ 

$laterespond=date("Y-m-d H:i:s",time()-60*60*$respondhours); 
$latefinalize=date("Y-m-d H:i:s",time()-60*60*$finalizehours); 

$challengeinfo=mysql_query("SELECT challid,challenger,challenged,ladderid,challengerrank,challengedrank,respondedby,finalizedby FROM challenges WHERE 
ladderid='$id' AND respondedby='0' AND finalizedby='0' AND challengedtime < '$laterespond' OR 
ladderid='$id' AND respondedby > '0' AND finalizedby='0' AND respondedtime < '$latefinalize'"); 
 while(list($challid,$challenger,$challenged,$ladderid,$challengerrank,$challengedrank,$respondedby,$finalizedby)=mysql_fetch_row($challengeinfo)){ 

//DIDNT RESPOND IN TIME or DIDNT FINALIZE IN TIME 
if(($respondedby=="0") && ($finalizedby=="0") || ($respondedby > 0) && ($finalizedby=="0")){ 
create_forfeit($challid,$id,$challenger,$challenged,$challengerrank,$challengedrank); 
} 

} 

} 

} 



function create_forfeit($challid,$ladderid,$winnerid,$loserid,$winrank,$loserank){ 
global $dir, $file, $url, $out, $plyr; 

$loserteaminfo=mysql_query("SELECT teamname FROM teams WHERE id='$loserid'"); 
$lteam=mysql_fetch_array($loserteaminfo); 

$winnerteaminfo=mysql_query("SELECT teamname FROM teams WHERE id='$winnerid'"); 
$wteam=mysql_fetch_array($winnerteaminfo); 

$ladderinfo=mysql_query("SELECT laddername FROM ladders WHERE id='$ladderid'"); 
$linfo=mysql_fetch_array($ladderinfo); 

$ip=getenv("REMOTE_ADDR"); 
$tday=date("Y-m-d H:i:s"); 

if(!$wteam[teamname]){ 
$wteam[teamname]="[DELETED]"; 
} 

if(!$lteam[teamname]){ 
$lteam[teamname]="[DELETED]"; 
} 

/* 
//REPORT MATCH TO MATCH DATABASE 
mysql_query("INSERT INTO matchdb VALUES ( 
'$challid', 
'$winnerid', 
'$loserid', 
'$wteam[teamname]', 
'$lteam[teamname]', 
'$ladderid', 
'$linfo[laddername]', 
'$winrank', 
'$loserank', 
'0', 
'0', 
'', 
'', 
'', 
'', 
'Win by forfeit.', 
'Loss by forfeit.', 
'0', 
'0', 
'$plry[id]', 
'$tday', 
'0.0.0.0', 
'$plry[id]', 
'$tday', 
'$ip');"); 
*/ 


[gothic]

Is there more code to the 'create_forfeit' function that is not being displayed?

[Legacy]

The Complete

challengeforfeit.php file posted below

other files belonging to the challenge-respond-finalize part of the sscript are

challenge.php
challengerespond.php
challengefinalize.php
If anyone needs to see these files let me know

PHP Code:

<?

function challenge_forfeit($challid){
global $dir, $file, $url, $out, $plyr;

if(!$challid){
include("$dir[func]/error.php");
display_error("Invalid Challenge ID.<br>");
}

$challengeinfo=mysql_query("SELECT * FROM challenges WHERE challid='$challid'");
$chall=mysql_fetch_array($challengeinfo);

if(!$chall[challenger]){
include("$dir[func]/error.php");
display_error("Unknown Challenge ID.<br>");
}

if($chall[finalizedby] > 0){
include("$dir[func]/error.php");
display_error("This match has already been finalized.<br>");
}


$teamembers=mysql_query("SELECT teamid FROM teammembers WHERE teamid='$chall[challenger]' AND playerid='$plyr[id]' AND status <= '3' OR teamid='$chall[challenged]' AND playerid='$plyr[id]' AND status <= '3'");
$tmem=mysql_fetch_array($teamembers);

if($tmem[teamid]=="$chall[challenger]"){
//CHALLENGER FORFEIT
$winnerid="$chall[challenged]";
$winrank="$chall[challengedrank]";
$loserid="$chall[challenger]";
$loserank="$chall[challengerrank]";
$ladderid="$chall[ladderid]";
}
else if($tmem[teamid]=="$chall[challenged]"){
//CHALLENGED FORFEIT
$winnerid="$chall[challenger]";
$winrank="$chall[challengerrank]";
$loserid="$chall[challenged]";
$loserank="$chall[challengedrank]";
$ladderid="$chall[ladderid]";
}
else{
include("$dir[func]/error.php");
display_error("You cannot forfeit challenges for this team.<br>");
}

create_forfeit($challid,$ladderid,$winnerid,$loserid,$winrank,$loserank);

$out[body]=$out[body]."
<table width='100%' border='1' bordercolor='#000000' cellspacing='1' cellpadding='1'>
<tr class='altcolor'>
<td width='100%' valign='top' align='center'>
<strong>Forfeited</strong><br>
</td>
</tr>
<tr>
<td width='100%' valign='center' align='left'>
<br><ul>
The challenge was forfeited.</ul></td>
</tr>
<tr class='altcolor'>
<td width='100%' valign='top' align='center'>
&nbsp;</td>
</tr>
</table>";

include("$dir[curtheme]");
}














//NEXT 2 FUNCTIONS DELETES AND AWARDS WINS FOR UNRESPONDED OR UNFINALIZED CHALLENGES


function check_unrespondedchallenges(){

$challengeladders=mysql_query("SELECT id,respondhours,finalizehours FROM ladders WHERE challenge='1'");
while(list($id,$respondhours,$finalizehours)=mysql_fetch_row($challengeladders)){

$laterespond=date("Y-m-d H:i:s",time()-60*60*$respondhours);
$latefinalize=date("Y-m-d H:i:s",time()-60*60*$finalizehours);

 $challengeinfo=mysql_query("SELECT challid,challenger,challenged,ladderid,challengerrank,challengedrank,respondedby,finalizedby FROM challenges WHERE 
 ladderid='$id' AND respondedby='0' AND finalizedby='0' AND challengedtime < '$laterespond' OR 
 ladderid='$id' AND respondedby > '0' AND finalizedby='0' AND respondedtime < '$latefinalize'");
 while(list($challid,$challenger,$challenged,$ladderid,$challengerrank,$challengedrank,$respondedby,$finalizedby)=mysql_fetch_row($challengeinfo)){

 //DIDNT RESPOND IN TIME or DIDNT FINALIZE IN TIME
 if(($respondedby=="0") && ($finalizedby=="0") || ($respondedby > 0) && ($finalizedby=="0")){
 create_forfeit($challid,$id,$challenger,$challenged,$challengerrank,$challengedrank);
 }
 
 }

}

}



function create_forfeit($challid,$ladderid,$winnerid,$loserid,$winrank,$loserank){
global $dir, $file, $url, $out, $plyr;

$loserteaminfo=mysql_query("SELECT teamname FROM teams WHERE id='$loserid'");
$lteam=mysql_fetch_array($loserteaminfo);

$winnerteaminfo=mysql_query("SELECT teamname FROM teams WHERE id='$winnerid'");
$wteam=mysql_fetch_array($winnerteaminfo);

$ladderinfo=mysql_query("SELECT laddername FROM ladders WHERE id='$ladderid'");
$linfo=mysql_fetch_array($ladderinfo);

$ip=getenv("REMOTE_ADDR"); 
$tday=date("Y-m-d H:i:s");

if(!$wteam[teamname]){
$wteam[teamname]="[DELETED]";
}

if(!$lteam[teamname]){
$lteam[teamname]="[DELETED]";
}

/* 
//REPORT MATCH TO MATCH DATABASE
mysql_query("INSERT INTO matchdb VALUES (
'$challid', 
'$winnerid', 
'$loserid', 
'$wteam[teamname]', 
'$lteam[teamname]', 
'$ladderid', 
'$linfo[laddername]', 
'$winrank', 
'$loserank', 
'0', 
'0', 
'', 
'', 
'', 
'', 
'Win by forfeit.', 
'Loss by forfeit.', 
'0', 
'0', 
'$plry[id]', 
'$tday', 
'0.0.0.0', 
'$plry[id]', 
'$tday', 
'$ip');");
*/


//GET WINNERS LADDER STATS
$winnerladder=mysql_query("SELECT * FROM ladder_$ladderid WHERE id='$winnerid'");
$wlinfo=mysql_fetch_array($winnerladder);

//GET LOSERS LADDER STATS
$loserladder=mysql_query("SELECT * FROM ladder_$ladderid WHERE id='$loserid'");
$llinfo=mysql_fetch_array($loserladder);


include("$dir[func]/rankadjust.php");

if(($loserank) && ($winrank)){
 if(($loserank < $winrank) && ($loserank < $wlinfo[rank])){ 
 update_teamranks($ladderid,$winnerid,$loserank);
 }
}


$tommorrow=date("Y-m-d H:i:s",time()+60*60*24*1);


//UPDATE WINNERS LADDER STATS

if($winrank < $loserank){
$newlastrank="$wlinfo[rank]";

 if(($winrank < $wlinfo[bestrank]) || ($wlinfo[bestrank] < 1)){
 $newbestrank="$loserank";
 }else{
 $newbestrank="$wlinfo[bestrank]";
 }

}else{
$newlastrank="$wlinfo[lastrank]";
$newbestrank="$wlinfo[bestrank]";
}

$newwins=($wlinfo[wins] + 1);
$newgames=($newwins + $wlinfo[losses]);
$newpercent=round($newwins / $newgames * 100);
$newstreak=($wlinfo[streak] + 1);

if($newstreak=="0"){
$newstreak="1";
}

if($newstreak > $wlinfo[beststreak]){
$newbeststreak="$newstreak";
}else{
$newbeststreak="$wlinfo[beststreak]";
}


mysql_query("UPDATE ladder_$ladderid SET 
lastmatch='$tday', 
lastplayed='$loserid', 
status='20', 
statusdate='$tommorrow', 
statusdisplay='Win by forfeit', 
lastrank='$newlastrank', 
bestrank='$newbestrank', 
wins='$newwins', 
games='$newgames', 
percent='$newpercent', 
streak='$newstreak', 
beststreak='$newbeststreak' 
WHERE id='$winnerid'");



//UPDATE LOSERS LADDER STATS

if($llinfo[rank] < $llinfo[bestrank]){
$newbestrank="$llinfo[rank]";
}else{
$newbestrank="$llinfo[bestrank]";
}

if($llinfo[rank] > $llinfo[worstrank]){
$newworstrank="$llinfo[rank]";
}else{
$newworstrank="$llinfo[worstrank]";
}

$newlosses=($llinfo[losses] + 1);
$newgames=($newlosses + $llinfo[wins]);
$newpercent=round($llinfo[wins] / $newgames * 100);
$newstreak=($llinfo[streak] - 1);

if($newstreak=="0"){
$newstreak="-1";
}

if($newstreak < $llinfo[worststreak]){
$newworststreak="$newstreak";
}else{
$newworststreak="$llinfo[worststreak]";
}


mysql_query("UPDATE ladder_$ladderid SET 
lastmatch='$tday', 
status='6', 
statusdate='$tommorrow', 
statusdisplay='Loss by forfeit', 
lastplayed='$winnerid', 
bestrank='$newbestrank', 
worstrank='$newworstrank', 
losses='$newlosses', 
games='$newgames', 
percent='$newpercent', 
streak='$newstreak', 
worststreak='$newworststreak' 
WHERE id='$loserid'");

mysql_query("DELETE FROM challenges WHERE challid='$challid'");

//CHECK FOR DUPLICATE RANKS AND ADJUST RANKS
rank_checkadjust($ladderid);

}



?>

[gothic]

Okay, I have a headache now.. =]

It's hard to only look at such little code without any runtime debugging and not seeing where some functions are called from... But here's my assessment... I could be wrong:

The function 'challenge_forfeit' appears to do the correct things. It *think* it checks if the match was finalized, and if it was, it swaps the winner from the challenger to the challenged.

On the other hand, it appears function 'check_unrespondedchallenges' just assumes the Challenger is the winner.
This may be the correct behavior, depending on how it's called, but I can't be sure without having the entire program to run.
That function may need to swap the winner/loser around like the 'challenge_forfeit' function, but I can't say for sure.

If you feel so inclined, and don't mind - email me the origional tarfile of this program, and I'll try to debug it further for you. Unless of course, someone else can see what I'm missing.. =]

[ChoaticWhisper]

I seen on another forum legacy posted the same question, It seems he got some help.
Heres what a person posted

PHP Code:

if(($respondedby=="0") && ($finalizedby=="0")){ 
  create_forfeit($challid,$id,$challenger,$challenged,$challengerrank,$challengedrank); 
} else if (($respondedby > 0) && ($finalizedby=="0")) {
  create_forfeit($challid,$id,$challenged,$challenger,$challengedrank,$challengerrank); 
} 


[Legacy]

Yes..I did get some help and thank EVERYONE that helped out.

There are ALOT more bugs in this crappy $400.00 rip-off script that I am trying to get fixed.

Thanks again to all that helped me out

[gothic]

You mean someone stole my thunder? dern.. *shakes his fist* ..

=]